-
Notifications
You must be signed in to change notification settings - Fork 30
Fixes and Section/Property tests #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes G-Node#260 id should be unique for every entity, therefore exclude it from equality check.
Closes G-Node#257 get_merged_equivalent lead to an AttributeError if the parent was not set.
jgrewe
approved these changes
Mar 21, 2018
achilleas-k
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various issues and pushes Section and Property tests.
idwhen comparing an odML entity for equality. Closes Exclude id in the baseobject.__eq__() method #260.get_path()when a Property has no parent. Closes [Property] AttributeError when calling get_path() with unset parent #256.get_merged_equivalentwhen a Property has no parent. Closes [Property] AttributeError when calling get_merged_equivalent() with unset parent #257.test_odMLMetadata.xmlwas removed.test_section: updatestest_id()and addstest_clone()test_property: updatestest_id()and addstest_get_path(),test_get_merged_equivalent()andtest_clone().test_property_integration: Adds the file to test saving and loading of Properties with all different parsers.