Drop VersionConverter broken XML file support #301
Merged
+7
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VersionConverter convered an edge case of xml files with opening <B0> tags that were missing its closing tag. Support for this is dropped to make sure file are always opened with the proper encoding via lxml instead.
achilleas-k
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VersionConverter dealt with an edge case of XML test files with opening
<B0>tags that were missing their closing tag rendering them broken. Catching this one edge case circumvented opening XML files vialxml, leaving the resulting document open to various encoding problems.This PR drops support to resolve the specific tag edge case in favour of properly opening XML files via
lxml.