Harmonize attribute naming with nixpy #307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to make working with odml and the odml part of nixpy more similar.
The
create_sectionmethod is added toDocumentandSectionand thecreate_propertymethod toSection. Thepropsalias attribute ofpropertiesis added toSectionto close #299.Let me know if I missed any nixpy attribute that should be ported to odml as well and whether we should unify
__repr__ofSectionandPropertyas well, since they are currently different.See also #308 for completeness of this topic.