Skip to content

Conversation

@mpsonntag
Copy link
Contributor

@mpsonntag mpsonntag commented Nov 5, 2018

This PR aims to make working with odml and the odml part of nixpy more similar.

The create_section method is added to Document and Section and the create_property method to Section. The props alias attribute of properties is added to Section to close #299.

Let me know if I missed any nixpy attribute that should be ported to odml as well and whether we should unify __repr__ of Section and Property as well, since they are currently different.

See also #308 for completeness of this topic.

@mpsonntag mpsonntag changed the title Harmonize attribute naming with nippy Harmonize attribute naming with nixpy Nov 5, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 77.959% when pulling 7ac9973 on mpsonntag:funcharm into 4ce2e1b on G-Node:master.

@achilleas-k
Copy link
Member

In addition to making __repr__ the same with nixpy which you brought up, we could also add the pprint pretty print method to odML.

Copy link
Member

@jgrewe jgrewe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtmt

@jgrewe jgrewe merged commit 6c86f9a into G-Node:master Nov 6, 2018
@mpsonntag mpsonntag deleted the funcharm branch November 6, 2018 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

harmonize attribute naming with nix

4 participants