Skip to content

RDF Writer Formats #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpsonntag merged 8 commits into from
Aug 19, 2019
Merged

RDF Writer Formats #322

mpsonntag merged 8 commits into from
Aug 19, 2019

Conversation

@fschrader1992
Copy link
Collaborator

@fschrader1992 fschrader1992 commented Aug 4, 2019

With this pull request:

@fschrader1992
[rdf_converter.py] Get File Extension
8f490e1 
Extract file extension if given in full file name.
Related to issue G-Node#213.
@fschrader1992
[rdf_converter.py] "Turtle" as Default Writer Format
c3e328c 
Related issue G-Node#214.
@fschrader1992
[RDFWriter] Handle Unsupported RDF Format
b0257ed 
Catch unsupported RDF Formats and Raise ValueError.

Related to issue G-Node#215.
@fschrader1992
[test_rdf_writer.py] Add test_get_rdf_str()
5469c03 
To check for unsupported RDF formats.
JuliaSprenger
JuliaSprenger reviewed Aug 4, 2019
View reviewed changes
JuliaSprenger
JuliaSprenger reviewed Aug 4, 2019
View reviewed changes
@coveralls
Copy link

coveralls commented Aug 4, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.05%) to 77.277% when pulling 5460606 on fschrader1992:master into 0c6b514 on G-Node:master.

mpsonntag
mpsonntag requested changes Aug 5, 2019
View reviewed changes
Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor changes from my end.

@fschrader1992
[rdf_converter.py] Change RDF Format Error Message
f140270 
List all keys in python 2 and 3.
@fschrader1992
[format_converter.py] Change RDF Format Error Message
a9ee81b 
List all keys in python 2 and 3.
@fschrader1992
[rdf_converter.py] Adjust Writer Test for RDF Formats
17c9306 
Check for RDF format extensions given in format dictionary.
@fschrader1992
[ConversionFormats] Put Dictionary into new tools/utils File
5460606 
Merge dictionaries for format conversion into utils file.
Contains dictionary with RDF conversion formats as well as
for all formats.
mpsonntag
mpsonntag approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good from my end, thanks a lot!

@mpsonntag mpsonntag merged commit ae2474d into G-Node:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuliaSprenger JuliaSprenger JuliaSprenger left review comments

@mpsonntag mpsonntag mpsonntag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RDFWriter breaks on unknown output format Add default RDFWriter format RDFWriter does not provide file extension

4 participants

@fschrader1992 @coveralls @JuliaSprenger @mpsonntag