Leaf Export and Property Handling #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method to export single leaf of odml document, starting at specified property.
Method to export single leaf of odml document, starting at specified section. Includes properties of selected section, but no subsections.
If format of value is wrong, e.g. with date, more info is given.
achilleas-k
approved these changes
Jan 14, 2020
mpsonntag
requested changes
Jan 14, 2020
Contributor
mpsonntag
left a comment
mpsonntag
left a comment
There was a problem hiding this comment.
Very nice PR! I added mostly minor comments for the leaf_export. The _validate_values method requires some updates.
I'll also add some additional thoughts to the export_leaf method on the main PR thread which were not in the issue specification and do not concern the commits to this point.
Contributor
|
With respect to the |
Move from _validate_values and check only for dtypes "date", "time" and "datetime".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request