Skip to content

List-Style Tuple Integration #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mpsonntag merged 4 commits into from
Jun 2, 2020
Merged

List-Style Tuple Integration #393

mpsonntag merged 4 commits into from
Jun 2, 2020

Conversation

@fschrader1992
Copy link
Collaborator

@fschrader1992 fschrader1992 commented Jun 2, 2020

This PR:

  • Allows processing of tuples given as a list instead of a string as well, when setting property values, appending or extending them. Closes List-Style Tuple Integration #392
  • Adds the related tests

@coveralls
Copy link

coveralls commented Jun 2, 2020

Coverage Status

Coverage increased (+0.05%) to 77.085% when pulling 9eac34d on fschrader1992:validation into 441432b on G-Node:master.

@fschrader1992
Copy link
Collaborator Author

fschrader1992 commented Jun 2, 2020

Checks for Code Quality:

  • Pylint
  • Rebase onto GNODE Master
  • Repeat Local Tests Python3.8
  • Repeat Local Tests Python2.7

mpsonntag
mpsonntag approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@mpsonntag mpsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpsonntag mpsonntag merged commit 66c97fc into G-Node:master Jun 2, 2020
@mpsonntag mpsonntag mentioned this pull request Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpsonntag mpsonntag mpsonntag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

List-Style Tuple Integration

3 participants

@fschrader1992 @coveralls @mpsonntag