feat(auth): fix unrestricted route access in UI#10
Closed
jescalada wants to merge 23 commits intoG-Research:mainfrom
Closed
feat(auth): fix unrestricted route access in UI#10jescalada wants to merge 23 commits intoG-Research:mainfrom
jescalada wants to merge 23 commits intoG-Research:mainfrom
Conversation
Merges OIDC libary updates.
jescalada
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage ? 61.88%
=======================================
Files ? 49
Lines ? 1805
Branches ? 0
=======================================
Hits ? 1117
Misses ? 688
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 tasks
This was
unlinked from
issues
Apr 24, 2025
fix(deps): update npm - li-cli - experimental/li-cli/package.json
…pendency-review.yml
chore(deps): update github-actions - workflows - .github/workflows/dependency-review.yml
chore: run npm audit fix
chore: bump by minor to v1.11.0
Collaborator
Author
|
PR contents merged in finos#961. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the route access issue (unlogged users and non-admins can no longer access any route).
The second issue, decoupling the routing and the layout (in other words, removing the common routes from /admin and refactoring them to something else, like /dashboard), will be done in a separate PR as it might be larger than expected.
It builds on top of #7, which should be merged first.
I deliberately omitted the E2E tests as the layout fix will change how routes work.