refactor(ts): refactor db module to use TS and ESM#27
Closed
jescalada wants to merge 28 commits intoG-Research:mainfrom
Closed
refactor(ts): refactor db module to use TS and ESM#27jescalada wants to merge 28 commits intoG-Research:mainfrom
db module to use TS and ESM#27jescalada wants to merge 28 commits intoG-Research:mainfrom
Conversation
This was referenced Mar 3, 2025
db module to use TS and ESMdb module to use TS and ESM
…-refactor-db-module
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage ? 51.70%
=======================================
Files ? 48
Lines ? 1671
Branches ? 53
=======================================
Hits ? 864
Misses ? 790
Partials ? 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…ples-manager chore(deps): update dependency @finos/git-proxy to ^1.9.3 - git-proxy-plugin-samples - plugins/git-proxy-plugin-samples/package.json
…es/git-proxy-cli/package.json
fix(deps): update dependency axios to ^1.8.4 - git-proxy-cli - packages/git-proxy-cli/package.json
Collaborator
Author
|
PR contents merged in finos#960. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR piggybacks on Fabio's TS config PR (#26) to refactor the entire db module (one of the "helper" modules available). I'm working on #18, but I think it's better to refactor on a module-by-module basis. This will avoid headaches with missing files and converting dependent files from CommonJS to ESM.
The PR also fixes configs to enable TS and ESM to work together and execute mocha tests without breaking.
I verified that nothing breaks by running unit tests and also using a Mongo DB cloud instance to test that the converted Mongo module generates the initial user as expected:
Note: Some types are missing and set to
anyfor simplicity. We should fill those in when we add strict TS linting.Changelog
/src/db/mongoto TS and ESM/src/db/mongoto TS and ESM