Unify agent prompt handling and update chat input UX#297
Merged
GCWing merged 1 commit intoGCWing:mainfrom Mar 30, 2026
Merged
Conversation
wgqqqqq
force-pushed
the
fix/unify-agentic-prompt-read-bounds
branch
from
df5913d to
bc69130
Compare
wsp1911
added a commit
to wsp1911/BitFun
that referenced
this pull request
Apr 7, 2026
…Context This removes the current_working_directory field introduced in GCWing#297. In the current implementation it overlaps with workspace semantics and is not meaningfully maintained in the main execution flow, so keeping it adds API and path-resolution complexity without real value. - remove current_working_directory from ToolUseContext - remove cwd-based path resolution branches - update tool context builders and tool validation paths - simplify related tests to workspace-root-only behavior
wsp1911
added a commit
that referenced
this pull request
Apr 7, 2026
…Context This removes the current_working_directory field introduced in #297. In the current implementation it overlaps with workspace semantics and is not meaningfully maintained in the main execution flow, so keeping it adds API and path-resolution complexity without real value. - remove current_working_directory from ToolUseContext - remove cwd-based path resolution branches - update tool context builders and tool validation paths - simplify related tests to workspace-root-only behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
cargo test -p tool-runtime truncates_when_total_char_budget_is_hitcargo test -p tool-runtime reads_multiple_lines_when_budget_allowscargo test -p bitfun-core always_uses_default_prompt_templatecargo check -p bitfun-desktopNotes