Merged
Conversation
handling of carbon and argon de-excitation gamma-rays
This was referenced Mar 4, 2023
Closed
Closed
mroda88
reviewed
Mar 5, 2023
mroda88
approved these changes
Mar 6, 2023
Member
mroda88
left a comment
mroda88
left a comment
There was a problem hiding this comment.
This looks very good now.
We need to run splines and tests
nusense
reviewed
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request combines commits from pull requests #242 (SuSAv2 EM MEC fixes), #255 (carbon + argon de-excitation gamma-rays), and #257 (new SBN configuration XMLs) in a harmonious way. It supersedes those pull requests and represents all changes needed to tag R-3_04_00.