[oshdb-filter] add additional geometry based filters#436
Merged
Conversation
14 tasks
14 tasks
14 tasks
54c7451 to
aaccc30
Compare
6e32c21 to
86c1b5a
Compare
Member
Author
|
this is now ready to be reviewed 😊 |
joker234
reviewed
Nov 2, 2022
Member
joker234
left a comment
There was a problem hiding this comment.
Overall very good test coverage. Thanks for the PR!
General remark: Tests could be organized to ensure more fine-grained test titles (e.g. use existing comments about geometry types and spilt tests there). @DisplayName could be used to set an explizit descriptive name for the test. For more hirarchy, @Nested could be used. Examples see: https://blogs.oracle.com/javamagazine/post/beyond-the-simple-an-in-depth-look-at-junit-5s-nested-tests-dynamic-tests-parameterized-tests-and-extensions
joker234
reviewed
Nov 2, 2022
joker234
reviewed
Nov 2, 2022
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
18e5251 to
d168a20
Compare
joker234
reviewed
Nov 3, 2022
Co-authored-by: Johannes Visintini <johannes.visintini@heigit.org>
joker234
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the following new filters:
perimeter– select polygons based on the length of their boundarygeometry.vertices– selects geometries by their number of points (note: the end point of polygon rings count twice)geometry.inners/geometry.outers– selects (multi)polygons by their number of parts (outer or inner rings)geometry.roundness– selects polygons by their compactness value (using the Polsby-Popper test score)geometry.squareness– selects geometries by their squareness value (see paper for the definition)Corresponding issue
See #311
todo
Checklist
I have adjusted the examples or created an issue in the corresponding repositoryI have adjusted the benchmark or created an issue in the corresponding repository