Debugging OnionSmoothInsight.load_from_json()#135
Merged
matteobecchi merged 2 commits intoGMPavanLab:mainfrom Nov 24, 2025
Merged
Debugging OnionSmoothInsight.load_from_json()#135matteobecchi merged 2 commits intoGMPavanLab:mainfrom
OnionSmoothInsight.load_from_json()#135matteobecchi merged 2 commits intoGMPavanLab:mainfrom
Conversation
matteobecchi
changed the title
OnionSmothInsight.load_from_json()
matteobecchi
changed the title
OnionSmothInsight.load_from_json()OnionSmoothInsight.load_from_json()
SimoneMartino98
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues: #134
Requested Reviewers: @SimoneMartino98 @andrewtarzia
The
OnionInsight.state_listattribute is converted todictwhen dumped to JSON, and then not converted back when loaded from JSON. Issues has been solved.The data type (
StateUniorStateMulti) is inferred and each element of thestate_listis converted back to the original format. In this way, theOnionInsightmethods work correctly even when the object is loaded from JSON file.