Lens fix and new tests#138
Merged
SimoneMartino98 merged 5 commits intoGMPavanLab:mainfrom Nov 25, 2025
Merged
Conversation
| ) | ||
|
|
||
|
|
||
| def test_nn( |
Collaborator
There was a problem hiding this comment.
Worth keeping this test?
Collaborator
Author
There was a problem hiding this comment.
created a new test folder for the number of neighbors (with case data).
andrewtarzia
approved these changes
Nov 24, 2025
matteobecchi
approved these changes
Nov 25, 2025
Collaborator
matteobecchi
left a comment
matteobecchi
left a comment
There was a problem hiding this comment.
Everything looks good! This is probably a good template for all future pytests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all;
Here we solve #137
This highlighted a lack in the testing phase that neglects the changes of shape between the
centersand theselection.I then rewrote the test using
case_datato include different combinations (differentr_cut,delay,n_jobsorcenters>selection,centers<selection,centers=selection)