GPII-795: Reference context implementation #307
Conversation
…ntext/condition evaluation
…d documentation.. Some issues remaining with tests
…component is destroyed and tests pass again
documentation/ContextManager.md
Outdated
…he change to using changeapplier
|
@amb26 Ready for a new round of review |
documentation/ContextManager.md
Outdated
There was a problem hiding this comment.
illuminance, not illuminosity or luminosity
|
@amb26 Ok, ready again |
… Fixed a few other minor issues pointed out by Mr. Antvanique
…irective of jshint was taken into account. Fixed new jshint errors
…irective of jshint was taken into account. Fixed new jshint errors
|
@amb26 Added more complete tests of the context integration, should be ready for another round of review |
tests/ContextIntegrationTests.js
Outdated
There was a problem hiding this comment.
I don't think I remember writing this : P
|
OK - It should be ready again now |
…namespace changes, fixes to the web-based tests
tests/ContextIntegrationTests.js
Outdated
There was a problem hiding this comment.
These tests fail for me when run from their own directory (or indeed from all-tests.js) I believe because of this hard-coded relative path. The failure is
Error: ENOENT, no such file or directory 'E:\source\gits\gpii\node_modules\universal\tests\tests\platform\linux\configs\linux-builtIn-config.json'
I think that relative paths by default are interpreted relative to the process working directory. You should follow the pattern in DevelopmentTests.js, annoying though it is, and explicitly resolve a path with respect to __dirname which is guaranteed to be the directory holding the module file itself.
|
Fixed path issue - ready for testing again |
|
oh, @simonbates I'm so gonna win the race |
…failure point for further investigation Merge branch 'master' into GPII-795 Conflicts: gpii/node_modules/contextManager/src/ContextManager.js gpii/node_modules/contextManager/test/ContextManagerTests.js tests/all-tests.js tests/web/html/all-tests.html
|
I've updated this branch to current master, which now has GPII-17 merged into it, into my own repo's branch. https://github.com/amb26/universal/tree/GPII-795 Unfortunately there is a problem with the tests, in that they do not actually verify that the context manager does anything on a context change - I have inserted the following failure line into the context manager impl, and all the tests still pass: Could you i) Investigate and correct the implementation of the test cases so that the test fails as it should, and then Cheers |
…cking the settings they should as pointed out by Mr. AnvaniQue
|
Thanks for the update to current master and GPII-17 @amb26 .. I have fixed the issue with the tests, so things should now work properly! Thanks for catching that issue and sorry for not having done so myself.. ready for another round of review |
3 participants
Temporary fall-back context handling implementation