-
Notifications
You must be signed in to change notification settings - Fork 62
GPII-2717: Night screen #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI job failed: https://ci.gpii.net/job/universal-tests/749/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/786/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/788/ |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/universal-tests/790/ |
|
test this please |
|
CI job passed: https://ci.gpii.net/job/universal-tests/792/ |
# Conflicts: # gpii/node_modules/testing/src/Mocks.js # tests/JournalIntegrationTests.js # tests/platform/windows/windows-builtIn-testSpec.js
|
CI job failed: https://ci.gpii.net/job/universal-tests/822/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/823/ |
# Conflicts: # testData/deviceReporter/acceptanceTests/win7_builtIn.json # testData/deviceReporter/installedSolutions.json # testData/solutions/win32.json5
|
CI job passed: https://ci.gpii.net/job/universal-tests/833/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/836/ |
|
|
||
| ## Limitations | ||
|
|
||
| * This solution is yet to support the strength or times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of limitation is this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean, but I've added clarity to it.
|
CI job failed: https://ci.gpii.net/job/universal-tests/858/ |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/universal-tests/883/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/905/ |
|
CI job failed: https://ci.gpii.net/job/universal-tests/911/ |
|
CI job passed: https://ci.gpii.net/job/universal-tests/912/ |
Here's the night-screen solution - it makes the screen colours warmer (blue is reduced, making it yellowy)
The main purpose is to demonstrate the settings handler in GPII/windows#167
See com_microsoft_windows_nightScreen.md