Skip to content

GPII-3102: Metrics QSS support#632

Merged
amb26 merged 7 commits intoGPII:masterfrom
stegru:GPII-3102
Aug 22, 2018
Merged

GPII-3102: Metrics QSS support#632
amb26 merged 7 commits intoGPII:masterfrom
stegru:GPII-3102

Conversation

@stegru
Copy link
Member

@stegru stegru commented Jul 19, 2018

Updated the metrics to record settings applied by the QSS. It works by monitoring the preferences in the current session's model. It assumes there will still be a session created even when there isn't a (real) user logged in.

⚠️ The QSS will need to be completed in order to test this properly (GPII/gpii-app#48).

Also fixed:

  • Duplication of some logged entries
  • Local time in timestamps (with timezone info)
  • Logging most non-character keys (in gpii-windows)

See also: GPII/windows#185

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/universal-tests/971/

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/universal-tests/983/

@gpii-bot
Copy link

CI job failed: https://ci.gpii.net/job/universal-tests/986/

@stegru
Copy link
Member Author

stegru commented Jul 25, 2018

It passes locally (honest).

ok to test - it broke itself, so it can fix itself.

17:03:03.825:  Sending a GET request to: /reset-pouch on port 1244
Error removing temporary directory: Rimraf failed to complete within 1000 milliseconds...
17:03:05.854:  express pouchdb instance 'ba6dby2n-206267' initalizing...
17:03:05.899:  express baseDir: '/tmp/pouchManagerTests'...
17:03:05.911:  Express stopped...
17:03:05.911:  Express server listening on port 1234
17:03:05.911:  Express started...
17:03:06.170:  Data loaded for database 'gpii'...
17:03:06.422:  Sending a GET request to: /gpii on port 1234
17:03:07.020:  Sending a GET request to: /gpii/_design/views/_view/findClientByOauth2ClientId?key=%22testComputer%22 on port 1234
17:03:07.617:  jq: FAIL: Module "Testing Pouch Manager" Test name "Testing the load and the reset processes" - Message: The response should have a reasonable status code - at sequence position 18 of 20
17:03:07.617:  jq: Expected: 200
17:03:07.617:  jq: Actual: 500
17:03:07.617:  jq: Source:     at Object.assertEquals (/home/vagrant/sync/universal/node_modules/infusion/tests/test-core/jqUnit/js/jqUnit.js:137:19)
    at Object.gpii.test.express.helpers.isSaneResponse (/home/vagrant/sync/universal/node_modules/gpii-pouchdb/node_modules/gpii-express/tests/js/lib/test-helpers.js:28:12)
    at gpii.tests.pouchManager.checkResponse (/home/vagrant/sync/universal/gpii/node_modules/pouchManager/test/pouchManagerTests.js:215:31)
    at togo (/home/vagrant/sync/universal/node_modules/infusion/tests/test-core/utils/js/IoCTestUtils.js:202:33)
    at wrapped (/home/vagrant/sync/universal/node_modules/infusion/tests/test-core/utils/js/IoCTestUtils.js:320:26)
    at fire (/home/vagrant/sync/universal/node_modules/infusion/src/framework/core/js/Fluid.js:1568:40)
    at IncomingMessage.<anonymous> (/home/vagrant/sync/universal/node_modules/kettle/lib/test/KettleTestUtils.http.js:132:13)
    at emitNone (events.js:111:20)
    at IncomingMessage.emit (events.js:208:7)
    at endReadableNT (_stream_readable.j .... [output suppressed at 1024 chars - for more output, increase fluid.logObjectRenderChars]
"{\"error\":\"OpenError\",\"reason\":\"IO error: /tmp/pouchManagerTests/gpii-mrview-ac9eefd3422f906a613ecb54cb900916/LOCK: No such file or directory\"}\n"

@gpii-bot
Copy link

CI job passed: https://ci.gpii.net/job/universal-tests/987/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants