Conversation
|
CI job failed: https://ci.gpii.net/job/windows-tests/510/ |
|
CI job failed: https://ci.gpii.net/job/windows-tests/511/ |
|
CI job passed: https://ci.gpii.net/job/windows-tests/546/ |
| jqUnit.assertTrue("Testing a registry key that always exists.", | ||
| gpii.deviceReporter.registryKeyExists("HKEY_CURRENT_USER", | ||
| "Software\\Microsoft\\Command Processor", "CompletionChar", "REG_DWORD")); | ||
| gpii.deviceReporter.registryKeyExists("HKEY_LOCAL_MACHINE", |
There was a problem hiding this comment.
Has this picked up something from some ancient/stray branch? The change looks reasonable, but why has it showed up in this diff?
There was a problem hiding this comment.
The removed key was added by the Wix installer compiler when it's installer, but now that wix has been removed, this key is no longer being created.
There was a problem hiding this comment.
Why did the Wix installer compiler tinker with the command processor completion char?
There was a problem hiding this comment.
I don't know.
There is the same key in HKEY_LOCAL_MACHINE. I wonder if the installer started cmd, which caused the value to be read from HKLM then written back to HKCU.
There was a problem hiding this comment.
oh I'm talking about the installer for WiX - the installation process of the Wix toolset.
|
CI job passed: https://ci.gpii.net/job/windows-tests/584/ |
# Conflicts: # Vagrantfile # provisioning/Installer.ps1
|
CI job passed: https://ci.gpii.net/job/windows-tests/585/ |
3 participants
Removed the installer - only the installer from gpii-app is required.