First start at cross validation#4766
Conversation
jperson1
left a comment
jperson1
left a comment
There was a problem hiding this comment.
Fantastic! Just a very minor suggestion, but everything is working as expected on my end.
| logger.error( | ||
| f"<SOT ERROR> Cross Validation Errors do not match: SAC {sac_errors}, Audit {audit_errors}" | ||
| ) |
There was a problem hiding this comment.
This does get hit for me when cross validating - but, the only difference is in the userID of submitted_by. Since we intended to change how this field works, that's expected.
We may see a significant number of these as we transition to the new models since an Auditor often creates the record (current submitted_by), and the Certifying Auditee has to hit the final submit button (future submitted_by). But the actual errors will be equivalent, so it's fine.
There was a problem hiding this comment.
Let me take a closer look at what we can do here. I want to ensure we don't break the submitted_by for migrated audits. I was trying to avoid adding a new field, but we may need to.
jadudm
left a comment
jadudm
left a comment
There was a problem hiding this comment.
Reviewed with HDMS, RN, JR. Looks good for merging into the long-lived branch and continued effort.
3 participants
Purpose
Add in the same logic for validations as in the SAC for the new SOT
How
Translated the Audit object into the same shape as the sac validation object. Searched for all usage of the shape and added logic for validating the Audit.
Testing Completed