Updating the API to account for audit table, and refactoring.#4845
Merged
Conversation
rnovak338
suggested changes
Apr 2, 2025
Contributor
rnovak338
left a comment
rnovak338
left a comment
There was a problem hiding this comment.
Great work on the API refactoring, I cross-checked to ensure nothing is missing from the original two files.
Linting, e2e, unit tests are passing on my end, I left two more comments for review before approval.
jrothacker
force-pushed
the
jr/source-of-truth/api
branch
from
e16fe03 to
742eee1
Compare
rnovak338
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We want to use the new Audit table everywhere that the previous sac table or dissemination tables were used previously.
How
This is updating the API app to use the audit table, adding new endpoints where it makes sense for both sac and audit to run in parallel.
Testing Done
Linting, Unit Tests, End to End, Manual Tests.