Updating the previous references validation to use Audit table#4849
Merged
Conversation
jrothacker
force-pushed
the
jr/source-of-truth/cross
branch
2 times, most recently
from
7edcc8a to
335f952
Compare
rnovak338
approved these changes
Apr 3, 2025
Contributor
rnovak338
left a comment
rnovak338
left a comment
There was a problem hiding this comment.
LGTM - and tests passed.
jrothacker
force-pushed
the
jr/source-of-truth/cross
branch
from
1549090 to
9656ba8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The cross validation step for findings prior references was not using the Audit table.
How
During the launch of SOT, if there is an audit with the report_id, we'll also check the audit table and compare any errors but continue to use the dissemination tables for SAC validation.
Post SOT launch, this logic can be removed and solely utilize the SOT.
Testing Completed
Linting, Unit Tests, E2E, Manual.