2025-04-03 | MAIN --> PROD | DEV (7b57a86) --> STAGING#4850
Merged
Conversation
* Removes spaces from prior reference numbers The code previously removed spaces before the comma; we want to remove spaces entirely. That is, regardless of whether we have 2023-001 ,2022-004 or 2023-001, 2022-004 or 2023-001 , 2022-004 they should all become 2023-001,2022-004 We already trim() the strings; this makes sure there are no internal spaces whatsoever. * Adding unit test No spaces should remain in the `prior_references` field after this transform is complete. * Removing unneeded import * Need to explicitly ignore a Flake8 warning We're trying to test the space at the end of a line... * Remove a whitespace? * Does this pass the linter? I really want the whitespace...
Co-authored-by: James Person <james.person@gsa.gov>
* Trimming prior reference strings This is a partner to a previous fix. When we pull prior reference strings, they might look like: * "2022-001" * "2022-001,2021-003" * "2022-001, 2021-003" * "2022-001 ,2021-003" * " 2022-001,2021-003" * ... We were splitting on a comma, but we could then be left with substrings that have whitespace at the beginning and/or end. This adds a `map()` that does a `trim()` on every string. This guarantees that there is no whitespace in the prior reference strings, and should eliminate some lookup/validation errors. * `strip()`, not `trim()` --------- Co-authored-by: James Person <jperson1@umbc.edu> Co-authored-by: James Person <james.person@gsa.gov>
asteel-gsa
added
autogenerated
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Terraform plan for staging Plan: 1 to add, 0 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.staging.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2025-04-01T10:53:47Z" -> (known after apply)
}
}
Plan: 1 to add, 0 to change, 1 to destroy.✅ Plan applied in Deploy to Staging Environment #344 |
Contributor
|
Terraform plan for production Plan: 1 to add, 1 to change, 1 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~ update in-place
-/+ destroy and then create replacement
Terraform will perform the following actions:
# module.domain.cloudfoundry_route.origin_route_connected[0] will be updated in-place
!~ resource "cloudfoundry_route" "origin_route_connected" {
!~ destinations = [
- {
- app_id = "5dac166f-2fb0-4e72-8d4d-4359191bf284" -> null
- app_process_type = "web" -> null
- id = "1017be0d-b11c-4241-a150-3a9abcc0dff4" -> null
- port = 8080 -> null
- protocol = "http1" -> null
},
+ {
+ app_id = "************************************"
+ app_process_type = (known after apply)
+ id = (known after apply)
+ port = (known after apply)
+ protocol = (known after apply)
},
]
id = "e83a78c3-6efc-4cf3-b5be-064693423601"
# (7 unchanged attributes hidden)
}
# module.production.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~ id = "*******************" -> (known after apply)
!~ triggers = { # forces replacement
!~ "always_run" = "2025-04-02T17:35:54Z" -> (known after apply)
}
}
Plan: 1 to add, 1 to change, 1 to destroy.📝 Plan generated in Pull Request Checks #4536 |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an auto-generated pull request to merge main into prod for a staging release on 2025-04-03 with the last commit being merged as 7b57a86