Skip to content

Inclusive Copying for Resubmissions#5535

Merged
jperson1 merged 6 commits into
mainfrom
jp/inclusive-resub-creation
Apr 9, 2026
Merged

Inclusive Copying for Resubmissions#5535
jperson1 merged 6 commits into
mainfrom
jp/inclusive-resub-creation

Conversation

@jperson1
Copy link
Copy Markdown
Contributor

@jperson1 jperson1 commented Apr 7, 2026

Inclusive Copying for Resubmissions

Related tickets

Description of changes

  • On resubmission creation, wwitches the exclusive list to an inclusive one. Now, we don't copy over record-specific info like the certifications, tribal consent, and cog/over.
  • Fix a bug with the XLSX upload/removal pages. If there is no uploaded_by, for example when a resubmission was just started, it should display more expected things. The removal should still display and work as expected.

How to test

  • Switch to this branch, run normally.
  • Create a new resubmission. Ensure it has an "optional" workbook upload. So, something with findings or additional EINs/UEIs/auditors. Verify the fields that are copied into it are correct.
  • Attempt to remove one of the "optional" workbooks. Verify there are no errors. Verify the field is actually removed in both the audit_singleauditchecklist and audit_audit tables.

Screenshots and recordings

The uploaded_by and removal link on a fresh resubmission:
image

jperson1 added 3 commits April 7, 2026 17:43
On upload, display the correct uploaded_by and removal link info

On delete, don't error due to `audit_audit` info being missing
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Meta Environments #1156

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026

Terraform plan for dev

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2026-04-09T15:47:49Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

❌ Plan not applied in Deploy to Development and Meta Environments #1156 (Plan has changed)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 80%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 92% 62%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 86%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 68%
audit.templatetags 100% 100%
audit.test_viewlib 100% 100%
audit.views 75% 52%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 98% 100%
curation.curationlib 88% 72%
curation.migrations 100% 100%
dissemination 90% 69%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 61% 43%
dissemination.templatetags 52% 6%
dissemination.views 67% 47%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 77% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 89% (22123 / 24954) 69% (2703 / 3922)

Minimum allowed line rate is 85%

@jperson1 jperson1 added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit 3effdf3 Apr 9, 2026
17 checks passed
@jperson1 jperson1 deleted the jp/inclusive-resub-creation branch April 9, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RESUB] Double-check what is copied over when a resubmission is created

2 participants