Skip to content

[RESUB] Resubmission Justification#5539

Merged
RanyeM merged 13 commits into
mainfrom
resub-selection-list
Apr 9, 2026
Merged

[RESUB] Resubmission Justification#5539
RanyeM merged 13 commits into
mainfrom
resub-selection-list

Conversation

@RanyeM
Copy link
Copy Markdown
Contributor

@RanyeM RanyeM commented Apr 8, 2026

Related tickets

#5503

Description of changes

  • Added a required material_change_reasons field to ResubmissionStartForm so users must select one or more material changes before starting a resubmission
  • Added MATERIAL_CHANGE_CHOICES to capture the supported reasons for resubmission
  • Updated the checkbox widget to use the usa-checkbox__input class so the field renders correctly with USWDS styling
  • Updated ResubmissionStartView.get() to pass the form and initial form_user_input into the template context
  • Updated ResubmissionStartView.post() to repopulate submitted values on validation errors using request.POST
  • Updated ResubmissionStartView.post() to save material_change_reasons to user.profile.entry_form_data along with existing resubmission metadata
  • Updated test_resubmission_start_view.py so POST requests include material_change_reasons where required
  • Added test coverage for the new required material_change_reasons validation

How to test

  • Start the app and log in
  • Go to Resubmit an Audit
  • Confirm the “Reason for resubmission” checkbox group appears above the report ID field
  • Confirm only one checkbox is shown per option and that the field is styled correctly
  • Try submitting without selecting any reason and confirm the form reloads with the error: Select at least one reason for resubmission.
  • Try submitting with a selected reason and an invalid report ID and confirm the existing report ID validation still appears
  • Try submitting with a selected reason and a valid report ID and confirm the user is redirected to report_submission:eligibility
  • Confirm material_change_reasons is saved in user.profile.entry_form_data
  • Run:
python manage.py test audit.tests.views.test_resubmission_start_view

Screenshots and recordings

Screenshot 2026-04-08 at 10 23 12 AM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Meta Environments #1157

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 8, 2026

Terraform plan for dev

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2026-04-09T15:47:49Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

✅ Plan applied in Deploy to Development and Meta Environments #1157

@RanyeM RanyeM requested a review from a team April 8, 2026 22:41
Comment thread .gitignore
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 80%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 92% 62%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 86%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 68%
audit.templatetags 100% 100%
audit.test_viewlib 100% 100%
audit.views 75% 52%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 98% 100%
curation.curationlib 88% 72%
curation.migrations 100% 100%
dissemination 90% 69%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 61% 43%
dissemination.templatetags 52% 6%
dissemination.views 67% 47%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 77% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 89% (22134 / 24966) 69% (2703 / 3922)

Minimum allowed line rate is 85%

@RanyeM RanyeM added this pull request to the merge queue Apr 9, 2026
Merged via the queue into main with commit bda36b2 Apr 9, 2026
17 checks passed
@RanyeM RanyeM deleted the resub-selection-list branch April 9, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants