Skip to content

Using SAM response to populate Gen Info#5559

Merged
phildominguez-gsa merged 8 commits into
mainfrom
pd/prefill-gen-info
Apr 17, 2026
Merged

Using SAM response to populate Gen Info#5559
phildominguez-gsa merged 8 commits into
mainfrom
pd/prefill-gen-info

Conversation

@phildominguez-gsa
Copy link
Copy Markdown
Contributor

@phildominguez-gsa phildominguez-gsa commented Apr 16, 2026

Related tickets

Description of changes

  • The AuditeeInfoForm now stores the SAM response. This is used to populate some more fields in user.profile.entry_form_data, which was already being used to populate gen info fields during sac creation.
  • Specifically, it's populating auditee_name, as well as the auditee address fields. It uses their mailing address, as opposed to physical address, which was greenlit by Lynn.
  • Some AuditeeInfoForm cleanup, like using gets, improving readability, and removing redundant is_valid()

How to test

  • Start making a submission as normal. When you get to gen info, the name and address fields should be populated

Screenshots and recordings

Idk if this necessitates screenshots but here you go:
image
image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Terraform plan for meta

No changes. Your infrastructure matches the configuration.
No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Meta Environments #1163

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026

Terraform plan for dev

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2026-04-16T15:48:09Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

✅ Plan applied in Deploy to Development and Meta Environments #1163

@github-actions
Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 80%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 92% 62%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 86%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 68%
audit.templatetags 100% 100%
audit.test_viewlib 100% 100%
audit.views 75% 52%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 98% 100%
curation.curationlib 88% 72%
curation.migrations 100% 100%
dissemination 91% 69%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 61% 43%
dissemination.templatetags 52% 6%
dissemination.views 67% 47%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 78% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 89% (22254 / 25086) 69% (2707 / 3926)

Minimum allowed line rate is 85%

@phildominguez-gsa phildominguez-gsa marked this pull request as ready for review April 17, 2026 13:20
@LynnMHouston
Copy link
Copy Markdown
Contributor

LynnMHouston commented Apr 17, 2026

Virginia State Audit Director, copying HHS OIG, made the case for mailing address (over physical address) in this ticket: https://fac-gov.zendesk.com/agent/tickets/8638

Copy link
Copy Markdown
Contributor

@jperson1 jperson1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@phildominguez-gsa phildominguez-gsa added this pull request to the merge queue Apr 17, 2026
Merged via the queue into main with commit 1b36dd1 Apr 17, 2026
17 checks passed
@phildominguez-gsa phildominguez-gsa deleted the pd/prefill-gen-info branch April 17, 2026 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SPIKE] Determine What Info Can Be Pre-Populated From SAM

3 participants