More fixes for resubission meta

[phildominguez-gsa]

Related tickets

• Nope

Description of changes

• Missed a few things from the last PR:
  • The old sac wasn't being saved with the new data
  • submission_status now becomes "resubmitted"
  • resubmission_meta.resubmission_status now becomes "deprecated_by_resubmission". This is the value we check on the resubmission start page.
  • Adds resubmitted to list of transitions
    • Had to refactor sac_transition() because of flake8 complexity

How to test

• Run resubmission-full
• All audit_singleauditchecklist.resbmission_meta values should be correct
• All audit_singleauditchecklist.submission_status should be correct
• Try to start resubmissions for the deprecated submissions. It should fail.
• My Submissions list should look correct. Clicking on a resubmission should work and have the correct resubmission banner.

[daryll]

if these are null then we should leave them out of the JSON obj

[daryll]

this works great!

should we set submission_status == deprecated_via_resubmission or do we keep it as 'disseminated' in the 'audit_singleauditchecklist' table?

[daryll]

this works great!

should we set submission_status == deprecated_via_resubmission or do we keep it as 'disseminated' in the 'audit_singleauditchecklist' table?

https://github.com/GSA-TTS/FAC/blob/main/backend/audit/check_resubmission_allowed.py#L20 states we keep it as 'disseminated' and our design doc does not mention changing the submission_status

[daryll]

it seems the backend tables are all correct now
although the first audit on the audit page now shows "In progress"

[github-actions]

Package	Line Rate	Branch Rate	Health
.	100%	100%	✔
api	98%	86%	✔
api.serializers	97%	88%	✔
api.views	91%	96%	✔
audit	95%	80%	✔
audit.cross_validation	97%	86%	✔
audit.fixtures	84%	50%	❌
audit.formlib	92%	62%	✔
audit.intakelib	89%	83%	➖
audit.intakelib.checks	92%	86%	✔
audit.intakelib.common	98%	82%	✔
audit.intakelib.transforms	100%	95%	✔
audit.management.commands	78%	17%	❌
audit.migrations	100%	100%	✔
audit.models	91%	69%	✔
audit.templatetags	100%	100%	✔
audit.test_viewlib	100%	100%	✔
audit.views	75%	52%	❌
census_historical_migration	96%	65%	✔
census_historical_migration.migrations	100%	100%	✔
census_historical_migration.sac_general_lib	92%	84%	✔
census_historical_migration.transforms	95%	90%	✔
census_historical_migration.workbooklib	68%	69%	❌
config	78%	37%	❌
curation	98%	100%	✔
curation.curationlib	88%	72%	➖
curation.migrations	100%	100%	✔
dissemination	91%	70%	✔
dissemination.analytics	27%	0%	❌
dissemination.forms	80%	30%	❌
dissemination.migrations	97%	25%	✔
dissemination.models	100%	100%	✔
dissemination.report_generation	21%	0%	❌
dissemination.report_generation.excel	32%	0%	❌
dissemination.searchlib	61%	44%	❌
dissemination.templatetags	52%	6%	❌
dissemination.views	67%	47%	❌
djangooidc	53%	38%	❌
djangooidc.tests	100%	94%	✔
report_submission	100%	96%	✔
report_submission.migrations	100%	100%	✔
report_submission.templatetags	74%	100%	❌
report_submission.views	78%	61%	❌
support	94%	75%	✔
support.migrations	100%	100%	✔
support.models	90%	50%	➖
tools	98%	50%	✔
users	95%	86%	✔
users.fixtures	100%	83%	✔
users.management	100%	100%	✔
users.management.commands	100%	100%	✔
users.migrations	100%	100%	✔
Summary	89% (22284 / 25121)	69% (2715 / 3934)	➖

Minimum allowed line rate is 85%

[daryll]

this all looks great!

many thx!