Skip to content

[DRAFT] Add a Healthcheck to the ClamAV Container#5600

Merged
jperson1 merged 7 commits into
mainfrom
jp/clamav-healthcheck
Apr 28, 2026
Merged

[DRAFT] Add a Healthcheck to the ClamAV Container#5600
jperson1 merged 7 commits into
mainfrom
jp/clamav-healthcheck

Conversation

@jperson1
Copy link
Copy Markdown
Contributor

@jperson1 jperson1 commented Apr 27, 2026

Tests were failing on file uploads. This could point to lots of different issues. There could have been updates to; Minio, our local dependencies or connection config, the ClamAV upstream, or container connections. We've only really poked with ClamAV in the days before the issues appeared.

Something may have changed in ClamAV that had it start up slower, or cause issues if our tests begin before it spins up.

Related tickets

  • N/A

Description of changes

  • Add a healthcheck to clamav-rest. Require a positive healthcheck before web comes up.
  • Add a -L flag to the mc install in the Dockerfile. Missing mc may cause the upload configs to be broken.

How to test

  • Spin things up locally, make sure it all runs right.
  • Eyeball the CI/CD tests.

Screenshots and recordings

  • N/A

@jperson1 jperson1 self-assigned this Apr 27, 2026
@jperson1 jperson1 marked this pull request as ready for review April 27, 2026 18:38
@jperson1 jperson1 requested a review from a team as a code owner April 27, 2026 20:36
@jperson1 jperson1 marked this pull request as draft April 27, 2026 21:13
@jperson1
Copy link
Copy Markdown
Contributor Author

Drafting while I continue to poke at the flakey tests.

@github-actions
Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 80%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 92% 62%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 86%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 68%
audit.templatetags 100% 100%
audit.test_viewlib 100% 100%
audit.views 75% 52%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 98% 100%
curation.curationlib 88% 72%
curation.migrations 100% 100%
dissemination 91% 70%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 61% 44%
dissemination.templatetags 52% 6%
dissemination.views 67% 47%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 78% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 89% (22269 / 25102) 69% (2713 / 3932)

Minimum allowed line rate is 85%

@jperson1 jperson1 marked this pull request as ready for review April 28, 2026 13:47
@jperson1 jperson1 added this pull request to the merge queue Apr 28, 2026
Merged via the queue into main with commit 4743f8e Apr 28, 2026
29 of 30 checks passed
@jperson1 jperson1 deleted the jp/clamav-healthcheck branch April 28, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants