Skip to content

Bumping esbuild-sass-plugin to 3.7.0#5614

Merged
phildominguez-gsa merged 4 commits into
mainfrom
pd/update-esbuild-sass-plugin
May 5, 2026
Merged

Bumping esbuild-sass-plugin to 3.7.0#5614
phildominguez-gsa merged 4 commits into
mainfrom
pd/update-esbuild-sass-plugin

Conversation

@phildominguez-gsa
Copy link
Copy Markdown
Contributor

Related tickets

Description of changes

  • Bumping esbuild-sass-plugin to 3.7.0
  • Changing buildOptions target to "es2020"
    • With the original list, I was seeing Transforming destructuring to the configured target environment. I initially tried updating them to "chrome80", "edge80", "firefox75", "safari13", but saw the same issue.
    • My understanding is that using this approach promises to esbuild that modern JS is being used. The modern browsers we care about all support it too.
    • If this is a bad idea for some reason lmk

How to test

  • make docker-first-run && docker compose up
  • App works as normal

@phildominguez-gsa phildominguez-gsa marked this pull request as ready for review May 4, 2026 19:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 80%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 92% 62%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 86%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 69%
audit.templatetags 100% 100%
audit.test_viewlib 100% 100%
audit.views 75% 52%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 94% 86%
curation.curationlib 91% 71%
curation.management.commands 46% 34%
curation.migrations 100% 100%
dissemination 90% 70%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 61% 44%
dissemination.templatetags 52% 6%
dissemination.views 67% 47%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 78% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 88% (22521 / 25462) 69% (2741 / 3994)

Minimum allowed line rate is 85%

@phildominguez-gsa phildominguez-gsa added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit 6a478f8 May 5, 2026
29 of 30 checks passed
@phildominguez-gsa phildominguez-gsa deleted the pd/update-esbuild-sass-plugin branch May 5, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants