Skip to content

Fixing off-by-one FY CSV naming#5626

Merged
phildominguez-gsa merged 1 commit into
mainfrom
pd/fy-csv-fix
May 8, 2026
Merged

Fixing off-by-one FY CSV naming#5626
phildominguez-gsa merged 1 commit into
mainfrom
pd/fy-csv-fix

Conversation

@phildominguez-gsa
Copy link
Copy Markdown
Contributor

@phildominguez-gsa phildominguez-gsa commented May 8, 2026

Related tickets

Description of changes

  • The CSV dumper was naming the FY CSVs using the starting year, instead of the "next" year, as it should be. This caused the FY26 CSV to be empty. Fixing that!

How to test

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 80%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 92% 62%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 86%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 69%
audit.templatetags 100% 100%
audit.test_viewlib 100% 100%
audit.views 75% 52%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 94% 86%
curation.curationlib 91% 71%
curation.management.commands 46% 34%
curation.migrations 100% 100%
dissemination 90% 70%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 61% 44%
dissemination.templatetags 52% 6%
dissemination.views 67% 47%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 78% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 88% (22525 / 25466) 69% (2741 / 3994)

Minimum allowed line rate is 85%

@phildominguez-gsa phildominguez-gsa added this pull request to the merge queue May 8, 2026
Merged via the queue into main with commit 87e7aea May 8, 2026
17 checks passed
@phildominguez-gsa phildominguez-gsa deleted the pd/fy-csv-fix branch May 8, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants