Skip to content

Adding banner for resubmitted audits#5627

Merged
phildominguez-gsa merged 2 commits into
mainfrom
pd/next-report-banner
May 13, 2026
Merged

Adding banner for resubmitted audits#5627
phildominguez-gsa merged 2 commits into
mainfrom
pd/next-report-banner

Conversation

@phildominguez-gsa
Copy link
Copy Markdown
Contributor

Related tickets

Description of changes

  • Adding a banner for the case where is deprecated via resubmission. I thought about having them both "resubmission" and "resubmitted" messages in the same banner, but I think it's less confusing with two separate ones. Open to opinions on that and the alert wording.
  • Fixing the floating . for @jperson1's sanity

How to test

  • Have a chain of 3+ submissions. This can be done with resubmission-full.
  • The first submission should just have the "Resubmitted via..." banner
  • The "middle" submissions should have "Resubmission of... completed." and "Resubmitted via..." messages
  • The last submission should just have "Resubmission of... completed."
  • Start a new resubmission. The top of the submission checklist should show "Resubmission of... in progress." as normal

Screenshots and recordings

image

@github-actions
Copy link
Copy Markdown
Contributor

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 86%
api.serializers 97% 88%
api.views 91% 96%
audit 95% 80%
audit.cross_validation 97% 86%
audit.fixtures 84% 50%
audit.formlib 92% 62%
audit.intakelib 89% 83%
audit.intakelib.checks 92% 86%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 91% 69%
audit.templatetags 100% 100%
audit.test_viewlib 100% 100%
audit.views 75% 52%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 78% 37%
curation 94% 86%
curation.curationlib 91% 71%
curation.management.commands 46% 34%
curation.migrations 100% 100%
dissemination 90% 70%
dissemination.analytics 27% 0%
dissemination.forms 80% 30%
dissemination.migrations 97% 25%
dissemination.models 100% 100%
dissemination.report_generation 21% 0%
dissemination.report_generation.excel 32% 0%
dissemination.searchlib 61% 44%
dissemination.templatetags 52% 6%
dissemination.views 67% 47%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 100% 96%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
report_submission.views 78% 61%
support 94% 75%
support.migrations 100% 100%
support.models 90% 50%
tools 98% 50%
users 95% 86%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 88% (22532 / 25479) 69% (2741 / 3994)

Minimum allowed line rate is 85%

@daryll daryll self-requested a review May 12, 2026 20:48
Copy link
Copy Markdown
Contributor

@daryll daryll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@phildominguez-gsa phildominguez-gsa added this pull request to the merge queue May 13, 2026
Merged via the queue into main with commit b33d683 May 13, 2026
17 checks passed
@phildominguez-gsa phildominguez-gsa deleted the pd/next-report-banner branch May 13, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants