This repository was archived by the owner on Aug 18, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to our Cloud.gov manifest.yml scale config and upgrade to use Elasticsearch 5.6 (latest in Cloud.gov offering).
Explain the motivation for making this change. What existing problem does the pull request solve?
Our production environment was using a deployment of Elasticsearch that was not meant for production. Additionally out app would go down during Cloud.gov maintenance because it is running as a single instance. This has presented problems for us in the past and this is our effort to avoid said issues.
As for the upgrade of Elasticsearch version, it just makes sense to keep up to date as much as possible. Our Elasticsearch mappings are already incompatible with the latest version of Elasticsearch and it will only get harder to migrate if we wait longer.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
All test are passing: