This repository was archived by the owner on Aug 18, 2021. It is now read-only.
Search improvements #250
Merged
Search improvements #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 19, 2018 20:17
- The query body has been simplified to use just the multi_match query with any filters that are passed in the query paramaters - the over use of bool, should, and must queries was removed. This was throwing the _score result off by making elasticsearch aggregate scores in a erroneos way. Multi_match query now has the type (best_match) explicit. More testing with over types could help improve the search results. The name field is given the highest weight followed by the fulltext analyzed version of itself. This change is focused on the repos index. It might be good to review the search being done with the terms index
- This makes the query compatible with versions 2.4, 5.x, and 6.x
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Search improvements for better user experience. Also updates Elasticsearch queries to be compatible with versions 2.4, 5.x, and 6.x.
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
Our search functionality was creating a horrible user experience. One of the main features of the site and API is the search functionality. These improvements promise to make these features better while creating a code foundation to iterate and add even more improvements.
Test plan (required)
Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.
Closing issues
Closes #159, close #249