Skip to content
This repository was archived by the owner on Aug 4, 2020. It is now read-only.

Conversation

@saracope
Copy link
Contributor

Summary

This PR fixes/implements the following bugs/features

  • 🚨BREAKING CHANGE: Modifies the quality tag scoring scale *see note below
  • Add aria-label to quality tags for accessibility
  • Changes the update-assets script so the prism css isn't being copied since we've changed to a custom theme that is more accessible
  • Updates @webcomponents/custom-elements to v1.2.4

*Note:
The scoring scale for the quality tags has been updated to align with the new data quality algorithm for code.gov. Updated info is below.

The quality-tag component will determine the corner tag to add (either high, medium, or low) based on the score value passed. The range for these is:

  • low: a score below 4
  • medium: a score greater than or equal to 4 and less than 6
  • high: a score higher than or equal to 6

See quality_tag.js to view the code for this logic.

@saracope saracope merged commit 384fa79 into master May 16, 2019
@saracope saracope deleted the sc_update-quality-tag branch May 16, 2019 10:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants