Merged
Conversation
Author
|
need to extend this to optionally take a tuple of functions, eg: as there's bound to be times we want to make more than one intervention at the HDim constructor level. |
2e4054d to
206023a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow passing of functions into a databaker dimension constructor to allow any required override/modification of dimension headers before they are pivoted.
HDim(cells, "My Dim", CLOSEST, ABOVE, apply=my_function)or even
HDim(cells, "My Dim", CLOSEST, ABOVE, apply=lambda x: x.strip())So basically a databaker parallel of the pandas
apply()method. Is uber performant (changing a single string beats changing a subset of a series hands down) and should lead to cleaner code with much less of a reliance on post processing.also test feature for same plus corrected a
givento athenfor test readability in an unconnected scenario (spotted in passing).