Merged
Conversation
mikeAdamss
reviewed
Feb 8, 2024
Contributor
mikeAdamss
left a comment
mikeAdamss
left a comment
There was a problem hiding this comment.
few comments but this is mostly there
mikeAdamss
reviewed
Feb 9, 2024
| else: | ||
| error_location = "JSON data" | ||
| # Create formatted message to be output on ValidationError | ||
| if error_msg or indent: |
Contributor
There was a problem hiding this comment.
Will this work as if error_msg is None or indent is None: to allow default kwargs of None?
My thinking is, I think this all makes sense and won't interfere with things, but we don't 100% know until we get into structured logs and the like, so I'm keen for a default behaviour of exactly what jsonschema usually does (so its obvious to a DE how to turn off the prettiness if they need to).
Contributor
Author
There was a problem hiding this comment.
Yup, this works - json.dumps default for indent is None.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_json_schema()added with tests. Function accepts schema as str, and data to be validated against schema as str or dict. Users can also include an optionalmsg(str) and specify the integer value to indent json output.TODO: Write README once function is approved.