Improve the read me and fix the import issues#7
Merged
Moasib-Arif merged 5 commits intomainfrom Jan 4, 2024
Merged
Conversation
mikeAdamss
reviewed
Jan 2, 2024
Contributor
mikeAdamss
left a comment
There was a problem hiding this comment.
A few tweaks to make around dependencies and installation but nothing major, give me a shout if I've explained badly.
RE test failure, its just failing as its looking to produce code coverage but no tests exist to run so it cant find any results.
for now just add a /tests/test_nothing.py file containing:
# TODO - remove as soon as we add our first test.
def test_nothing():
"""
Empty test to stop failures for 0 coverage
"""
...
And that'll move us to a green tick.
Signed-off-by: Moasib-Arif <moasib_arif@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes: