Merged
Conversation
mikeAdamss
reviewed
Jan 10, 2024
Contributor
mikeAdamss
left a comment
There was a problem hiding this comment.
this is a very complex thing that's not really doing what I though it was doing (nobodies fault, the api logger was a rush merge and it shows a bit).
I've tried to leave comments, but broadly:
- make a script that imports DpLogger and does a bunch of logging statements, there's similar in one of my comments.
- make sure to
configure_logger()in the init. I'm not sure that should be a separate function tbh but we'll figure that out at the real PR. - at that point when you run your script it'll be punting json logs into your terminal
- from there it's just twiddling them into the right structures to meet the DP logging standards.
Contributor
|
@SarahJohnsonONS - had a binge on this and pushed code to it. Logger should be working and pumping out json lines now and I've sketched how we can test it with a few comments. can you have a look and get back to me if it doesn't make sense? It's much simpler like this. |
NickPapONS
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the required functionality implemented, but I'm a bit stuck on certain parts. See the comments in logger.py (prefaced with #4 for ease of searching).