Orchestra of the Phantom Hands Improvements #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld be identical, but there is a lot less nesting now.
…r renamed routing foci with the same name.
…e name and what they do is more obvious thanks to having extra space.
…probably better than defaulting to English ones.
koolkrafter5
changed the title
Author
|
If you want to test this, this guide and the pages for the foci are pretty good, except that only the non-focus items in the output focus chest have any effect (I did not change this, that's how it was originally). That means that the items in the input chest do not control the Global routing focus and it takes everything, which inspired the ability to rename them. |
Dream-Master
added
the
🚧 Testing on Zeta
serenibyss
reviewed
May 25, 2025
Member
serenibyss
left a comment
serenibyss
left a comment
There was a problem hiding this comment.
Thanks for the PR! I have some preliminary comments before I test this in-game
src/main/java/WayofTime/alchemicalWizardry/common/items/routing/OutputRoutingFocus.java
Show resolved
Hide resolved
src/main/java/WayofTime/alchemicalWizardry/common/routing/RoutingFocusLogicIgnMeta.java
Show resolved
Hide resolved
src/main/java/WayofTime/alchemicalWizardry/common/routing/RoutingFocusLogicLimitGlobal.java
Show resolved
Hide resolved
src/main/java/WayofTime/alchemicalWizardry/common/routing/RoutingFocusLogicMatchNBT.java
Show resolved
Hide resolved
src/main/java/WayofTime/alchemicalWizardry/common/routing/RoutingFocusLogicModItems.java
Show resolved
Hide resolved
src/main/java/WayofTime/alchemicalWizardry/common/items/routing/RoutingFocus.java
Show resolved
Hide resolved
serenibyss
approved these changes
May 26, 2025
serenibyss
removed
the
🚧 Testing on Zeta
DrParadox7
pushed a commit
to DrParadox7/BloodMagic
that referenced
this pull request
Dec 31, 2025
Co-authored-by: Maya <10861407+serenibyss@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this pr (aside from the general refactor this code really needed) is to allow players to rename input/output foci so they only interact with other foci in the same ritual that share the name. This was most needed for the output focus (global), because it would pull from every input in the ritual with no filter, but it can probably be a nice utility for the other foci as well. Unnamed input/output foci will all interact with each other, so existing setups should be unaffected since players had no reason to rename them before.
Because players will be renaming them, the output foci have a new line in their tooltip that explains their logic better than the previous names did. Some examples:
Default Output Routing Focus:
Output Routing Focus (Ignore Meta):
Output Routing Focus (Global):
I also improved the translation of the values for the "Direction:" tag in the tooltip for Russian and Chinese (I speak neither language, but those ones already had suitable translation keys). Previously, these values were displayed in English (SOUTH, EAST, etc):
Translations for the new "Logic" tag are welcome.