[Memory-opti:fix leak] Fix WorldServer leak #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out when you unregister a forge event class instance, that class instance is still referenced in forge's event system thus not getting garbage collected
So I manually clear the World map data when unregistering the event to avoid leaking the World object.
On top of that the mod used the
FMLServerStoppingEventto clear the data which fires too early, before theWorldEvent.Unloadevent fires on the server side. So by using theFMLServerStoppedEventinstead the event handler can now run properly and clear the world map.