Skip to content

Conversation

@UltraProdigy
Copy link
Member

@UltraProdigy UltraProdigy commented Aug 20, 2025

Changes:

  • Adds better interactive functionality for large fluid cells, gt, ic2, flasks, buckets, klein bottle (Any FC / IFCI) to BC Tanks, Iron Tanks, and Iron Tank Carts
  • Allows stacked cells in inventory to interact properly
  • Allows for stacked iron tanks to function correctly with cells (will add all at once & drain one tank at a time- clickable anywhere on structure stack)
  • Allows for creative mode interaction without altering inventory
  • Allows for proper interaction despite full inventory space
  • Preserves Debug Functionality

This is a follow up to both this change GTNewHorizons/GT-New-Horizons-Modpack#20745 and my PR altering the interactive functionality between cells and ender tanks GTNewHorizons/EnderStorage#20, very similar logic. The one key difference here is that filling a tank from a container is done normally but filling a container from a tank is done while SNEAKING. The reason for this is to allow the multiblock stack feature of iron tanks to function properly with the cells.

This is all tested extensively in latest of course. A short video is down below, there is no before video but before it only worked with single cells and buckets- was glitchy using other containers. Video does not depict inv overflow dropping, creative mode, or debug mode. LMK if you need that (or just test it out yourself, tis an accessible branch)

In-Game Video

GT_.New.Horizons.2.2.mp4

@UltraProdigy UltraProdigy added Bug Fix Fixes Bug. Please Link in PR Enhancement New feature or request labels Aug 20, 2025
@Dream-Master Dream-Master requested a review from a team August 25, 2025 17:24
@UltraProdigy UltraProdigy added Bug Fix Fixes Bug. Please Link in PR and removed Bug Fix Fixes Bug. Please Link in PR labels Sep 20, 2025
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Oct 1, 2025
@danyadev
Copy link
Member

danyadev commented Nov 8, 2025

i'm not sure about sneaking logic. I'd expect to not interact with block while i'm sneaking, thus allowing to place a tank above. Just like we can add a block near chest while sneaking instead of opening it

upd: I just realized that when you're trying to place a block on top of any other block and you're holding shift, the onBlockActivated method doesn't get called, so you can place a tank above another tank

Copy link
Member

@danyadev danyadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had a bit of experience with IFluidContainerItem and IFluidHandler lately, so decided to review your pr

@Dream-Master Dream-Master merged commit d861e0e into master Nov 16, 2025
1 of 2 checks passed
@Dream-Master Dream-Master deleted the BC-Tank-Fix branch November 16, 2025 09:13
@Dream-Master Dream-Master removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Fix Fixes Bug. Please Link in PR Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants