-
Notifications
You must be signed in to change notification settings - Fork 6
Fixes BC Tank Interaction with All Cell Types #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
i'm not sure about sneaking logic. I'd expect to not interact with block while i'm sneaking, thus allowing to place a tank above. Just like we can add a block near chest while sneaking instead of opening it upd: I just realized that when you're trying to place a block on top of any other block and you're holding shift, the |
danyadev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a bit of experience with IFluidContainerItem and IFluidHandler lately, so decided to review your pr
Changes:
This is a follow up to both this change GTNewHorizons/GT-New-Horizons-Modpack#20745 and my PR altering the interactive functionality between cells and ender tanks GTNewHorizons/EnderStorage#20, very similar logic. The one key difference here is that filling a tank from a container is done normally but filling a container from a tank is done while SNEAKING. The reason for this is to allow the multiblock stack feature of iron tanks to function properly with the cells.
This is all tested extensively in latest of course. A short video is down below, there is no before video but before it only worked with single cells and buckets- was glitchy using other containers. Video does not depict inv overflow dropping, creative mode, or debug mode. LMK if you need that (or just test it out yourself, tis an accessible branch)
In-Game Video
GT_.New.Horizons.2.2.mp4