CoFH Core runobf fix #128
Merged
CoFH Core runobf fix #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eigenraven
force-pushed
the
cofh-core-runobf-fix
branch
from
1a7971c to
b442640
Compare
OneEyeMaker
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few mods depend on CoFH Core using a specifier like:
curse.maven:cofh-core-69162:2388751. This point to the dev jar of cofh core on curseforge. A proper specifier that works with runObfClient/Server would becurse.maven:cofh-core-69162:2388750-dev:dev, but because it counts as a lower version than the dev jar, gradle will break if those two are mixed in a dependency tree. Therefore I propose to override it at a buildscript level for the obfuscated configurations for all mods. Tested with GT5u.