Skip to content

Conversation

@Glease
Copy link

@Glease Glease commented Feb 10, 2023

  • add a default project output path: Sometimes this is left empty somehow and IDEA complains if you try the native build. This gives a reasonable default.
  • add option to override build type to gradle/native automatically: thanks raven for finding this idea-ext plugin. finally a headache solved.

Signed-off-by: Glease 4586901+Glease@users.noreply.github.com

* add a default project output path: Sometimes this is left empty somehow and IDEA complains if you try the native build. This gives a reasonable default.
* add option to override build type to gradle/native automatically: thanks raven for finding this idea-ext plugin. finally a headache solved.

Signed-off-by: Glease <4586901+Glease@users.noreply.github.com>
Signed-off-by: Glease <4586901+Glease@users.noreply.github.com>
Signed-off-by: Glease <4586901+Glease@users.noreply.github.com>
@Glease Glease requested a review from a team February 10, 2023 19:27
@Glease Glease marked this pull request as draft February 10, 2023 19:41
Signed-off-by: Glease <4586901+Glease@users.noreply.github.com>
@Glease
Copy link
Author

Glease commented Feb 10, 2023

@eigenraven Hi, I need your help here. LWJGL libraries are marked as provided in IDEA (somehow), hence don't really show up when you use native IJ runs. However, if one does include provided scope in native IJ runs, you end up with compileOnly dependencies on classpath as well. What should we do here?
image

@eigenraven
Copy link
Member

I have to find the documentation (or probably source code) of how intellij exactly converts gradle dependencies into its own. I keep all minecraft dependencies together in one "configuration" (patchedMinecraft) except lwjgl so that different run configurations can use different lwjgl versions, there's probably a mapping I could add somewhere to modify how IJ sees these.

}
}
}
withIDEAFileXml("misc.xml") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is something that needs further testing with the three IJ configurations: folder-based, file-based and implicit (no files) projects imported from gradle, iirc the xml functions were causing me trouble in one of these

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would assume everyone is using imported from gradle, no? And if they don’t import from gradle this won’t run at all right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant this thing, though apparently file-based projects are now deprecated, I didn't realise it: https://www.jetbrains.com/help/idea/creating-and-managing-projects.html#file-based

@eigenraven eigenraven mentioned this pull request Feb 13, 2023
eigenraven added a commit that referenced this pull request Feb 16, 2023
@mitchej123 mitchej123 deleted the feature/idea-integration-imporve branch June 4, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants