-
Notifications
You must be signed in to change notification settings - Fork 197
rebalance lanterns to be usable as decorations #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
chochem
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are 4 lanterns that all follow the same recipe pattern, this only changes some.
|
I also got to say, I am not a huge fan of the new recipes.
bonus question: did you check for conflicts? iron plates in assembler are common :P |
|
|
||
| @Override | ||
| public void loadRecipes() { | ||
| long bits = GTModHandler.RecipeBits.NOT_REMOVABLE | GTModHandler.RecipeBits.REVERSIBLE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont seem to be using this for bibliocraft
| GTModHandler.addCraftingRecipe( | ||
| getModItem(EtFuturumRequiem.ID, "lantern", 1, 0, missing), | ||
| getModItem(EtFuturumRequiem.ID, "lantern", 2, 0, missing), | ||
| bits, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it actually making recycling recipes? If so that would probably not be good as you have a discount assembler recipe.
However this was already here and I dont see any in dailies, so maybe it is broken anyway.
|
thanks! I added some code comments. it looks like you didnt want to match torch and lantern count? It is confusing though. on discord you are saying 'i do think im not gonna split the torch' but then you are very much still splitting the one torch into 2 lanterns. |
(soul lantern folllows the same with their respective torch)