Skip to content

Conversation

@Spicierspace153
Copy link
Contributor

image image

(soul lantern folllows the same with their respective torch)

@Spicierspace153 Spicierspace153 changed the title Kat/lantern buf rebalance lanterns to be usable as decorations Dec 15, 2025
@Spicierspace153 Spicierspace153 added enhancement safe for stable Bugfix with low break chance for patch releases refactor For PRs rewritting a part of the code to have a nicer code overall. labels Dec 15, 2025
@Nockyx Nockyx enabled auto-merge (squash) December 15, 2025 01:29
Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 4 lanterns that all follow the same recipe pattern, this only changes some.

@chochem chochem disabled auto-merge December 15, 2025 01:31
@chochem chochem added Affects Balance Requires admin approval before merging and removed enhancement safe for stable Bugfix with low break chance for patch releases refactor For PRs rewritting a part of the code to have a nicer code overall. labels Dec 15, 2025
@chochem
Copy link
Member

chochem commented Dec 15, 2025

I also got to say, I am not a huge fan of the new recipes.

  • Every lantern should be one torch for sure, you are not splitting torches.
  • And the iron cost should probably be reversed. makes no sense that it goes up with the assembler.

bonus question: did you check for conflicts? iron plates in assembler are common :P


@Override
public void loadRecipes() {
long bits = GTModHandler.RecipeBits.NOT_REMOVABLE | GTModHandler.RecipeBits.REVERSIBLE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont seem to be using this for bibliocraft

GTModHandler.addCraftingRecipe(
getModItem(EtFuturumRequiem.ID, "lantern", 1, 0, missing),
getModItem(EtFuturumRequiem.ID, "lantern", 2, 0, missing),
bits,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it actually making recycling recipes? If so that would probably not be good as you have a discount assembler recipe.

However this was already here and I dont see any in dailies, so maybe it is broken anyway.

@chochem
Copy link
Member

chochem commented Dec 15, 2025

thanks! I added some code comments.

it looks like you didnt want to match torch and lantern count? It is confusing though. on discord you are saying 'i do think im not gonna split the torch' but then you are very much still splitting the one torch into 2 lanterns.
But not the most crictical thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects Balance Requires admin approval before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants