Fix Auto Crafter able to craft items with different NBT #60
Conversation
Make it match NBT
Dream-Master
added
the
🚧 Testing on Zeta
|
Did you test https://github.com/GTNewHorizons/Dupes-Exploits-GTNH/issues/220, in my testing it did not fix that Issue ( but the forge microblock one (https://github.com/GTNewHorizons/Dupes-Exploits-GTNH/issues/220#issuecomment-3649333078)? I made #63 which (in my testing atleast) fixed everything |
The target of this PR is the major dupe itself, nothing else. This can still be merged to address it and then from this you implement your rework to fix the rest of issues from project bench and autocrafting bench And I'm more interested into getting this merged first as it's a quick and simple PR and then from this we can look for your big refactor which will take more time to review and test 👍 |
| eq.matchNBT = true | ||
| eq.matchOre = currentRecipe.isInstanceOf[ShapedOreRecipe] || currentRecipe | ||
| .isInstanceOf[ShapelessOreRecipe] |
There was a problem hiding this comment.
The Issue here is that you also need to set matchOre to false, as PamsHarvest craft and many other mods register the recipe as ShapelessOreRecipe ( even when not using any items with OreDict matching in the recipe)
There is an early return for the matchOre
I mean i guess it will fix the forge microblocks thing, as that uses its own RecipeClass
Make it match NBT
BREAKING: This PR will fix unwanted behavior of the Auto Crafting Bench. But will break crafts relying on mismatching NBT from the original recipe plan and the craft being done. (e.g: Renamed items, enchanted items...)