Skip to content

Conversation

@devpikachu
Copy link

@devpikachu devpikachu commented Dec 30, 2025

a bit related to GTNewHorizons/GT-New-Horizons-Modpack#20846 but does not fix glitching into the ground.
Fixes GTNewHorizons/GT-New-Horizons-Modpack#21701

Small refactoring to extract tag names to constants, make the Mantle of the Raven default to disabled instead of enabled, disable the mantle automatically on unequip and prevent overwriting its state.

It's worth noting that for GTNewHorizons/GT-New-Horizons-Modpack#21701, it's the behavior explained in the comment that got fixed. The behavior outlined in the ticket itself cannot be reproduced with the latest release of Witching Gadgets.

@UltraProdigy
Copy link
Member

Wasn't this already fixed by #103 ? @chochem

@devpikachu
Copy link
Author

Wasn't this already fixed by #103 ? @chochem

I was able to reproduce the issues linked on latest master, but I might've missed something.

@UltraProdigy
Copy link
Member

Oh, fair enough if it is still broken in daily I guess it was never fixed Lol.

@chochem
Copy link
Member

chochem commented Dec 30, 2025

Wasn't this already fixed by #103 ? @chochem

certainly remembering its state just fine for me. I have not heard of any issues either

@devpikachu devpikachu changed the title Fix Mantle of the Raven not remembering its state Prevent Mantle of the Raven re-enabling automatically on equip Dec 30, 2025
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mantle of the raven glide can't be disabled

5 participants