feat(Order): 주문 조회 N + 1 문제 해결

[Jjiggu]

작업 요약

• 주문 목록 조회 시 발생하는 N + 1 문제 해결
• EntityGraph 적용

Issue Link

#132

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 버그 수정
  • 매장별 주문 내역 조회 시, 주문 항목과 해당 메뉴 정보가 함께 불러와져 더 빠르고 정확한 데이터 확인이 가능합니다.

[coderabbitai]

Walkthrough

OrderRepository의 findAllByStore_StoreId 메서드에 @EntityGraph 어노테이션이 추가되어, 해당 메서드 호출 시 관련된 orderItems 및 그 하위의 menu 엔티티가 즉시 로딩되도록 변경되었습니다. 다른 메서드나 로직은 수정되지 않았습니다.

Changes

파일/경로	변경 요약
.../order/repository/OrderRepository.java	findAllByStore_StoreId에 @EntityGraph 어노테이션 추가

Sequence Diagram(s)

sequenceDiagram
    participant Service
    participant OrderRepository
    participant Database

    Service->>OrderRepository: findAllByStore_StoreId(storeId)
    OrderRepository->>Database: SELECT UserOrder + JOIN orderItems + JOIN menu
    Database-->>OrderRepository: UserOrder + orderItems + menu
    OrderRepository-->>Service: List<UserOrder> (with orderItems, menu)

Loading

Estimated code review effort

1 (~2 minutes)

Possibly related issues

• [백엔드] 주문 조회 시 N + 1 문제 발생 #135: findAllByStore_StoreId에 @EntityGraph를 추가하여 N+1 문제를 해결하는 변경으로, 해당 이슈의 목적을 직접적으로 해결합니다.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6447c44 and c66487f.

📒 Files selected for processing (1)

• nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/order/repository/OrderRepository.java (2 hunks)

🔇 Additional comments (2)

nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/order/repository/OrderRepository.java (2)

6-6: EntityGraph import 추가 확인됨.

N+1 문제 해결을 위한 @entitygraph 어노테이션 사용에 필요한 import가 올바르게 추가되었습니다.

---

18-19: N+1 문제 해결을 위한 EntityGraph 적용이 적절합니다.

@EntityGraph(attributePaths = {"orderItems", "orderItems.menu"}) 어노테이션이 올바르게 적용되어:

• orderItems 컬렉션과 중첩된 menu 엔티티들이 단일 쿼리로 즉시 로딩됩니다
• 기존의 N+1 쿼리 문제가 효과적으로 해결됩니다
• 스토어별 주문 목록 조회 시 성능이 크게 개선될 것으로 예상됩니다

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.