Refactor: 이미지 리사이징 도입

[Jjiggu]

작업 요약

• AWS Lambda를 활용한 이미지 리사이징 도입
• 이미지 url 리사이징 버킷으로 변경

Issue Link

#4

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 버그 수정

  • 메뉴 및 매장 이미지 저장 시 원본 이미지 URL 대신 리사이즈된 이미지 URL이 저장되도록 변경되었습니다.
  • 매장 이미지 삭제 시 파라미터명이 명확하게 변경되었습니다.

• 리팩터링

  • 이미지 업로드 및 삭제 기능이 원본과 리사이즈 버킷을 모두 처리하도록 개선되었습니다.
  • 반환값 및 파라미터 명칭이 명확하게 정리되었습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

"""

Walkthrough

이번 변경사항은 이미지 업로드 및 저장 로직에서 리사이즈된 이미지 URL을 사용하도록 서비스 계층을 수정하고, S3Service가 오리지널 및 리사이즈 버킷을 모두 지원하도록 구조를 변경했습니다. 일부 컨트롤러의 파라미터 명칭 및 반환문 포맷도 개선되었습니다.

Changes

파일/경로 그룹	변경 요약
.../menu/controller/MenuImageController.java	반환문을 멀티라인 포맷으로 리포맷. 기능적 변화 없음.
.../store/controller/StoreImageController.java	deleteStoreImage 메서드의 파라미터명을 imageId → storeImageId로 변경.
.../menu/service/MenuImageService.java	이미지 저장 시 오리지널 URL 대신 리사이즈된 이미지 URL을 저장하도록 수정.
.../store/service/StoreImageService.java	배너/프로필 이미지 저장 시 타입 문자열(store→banner/profile) 및 저장 URL(오리지널→리사이즈) 변경.
.../infraaws/aws/s3/S3Service.java	단일 버킷 → 오리지널/리사이즈 버킷 분리, S3UploadResult에 URL 2개로 확장, 삭제 시 두 버킷 모두 처리.

Sequence Diagram(s)

sequenceDiagram
    participant Controller
    participant Service
    participant S3Service
    participant S3OriginalBucket
    participant S3ResizeBucket

    Controller->>Service: 이미지 업로드 요청
    Service->>S3Service: upload(type, refId, file)
    S3Service->>S3OriginalBucket: 파일 업로드
    S3Service->>S3Service: originalUrl, resizedUrl 생성
    S3Service-->>Service: S3UploadResult(key, originalUrl, resizedUrl)
    Service->>Service: 리사이즈 URL로 엔티티 저장
    Service-->>Controller: 저장 결과 반환

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15–20분
"""

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c99178e and ff98ed5.

📒 Files selected for processing (5)

• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/menu/controller/MenuImageController.java (1 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/menu/service/MenuImageService.java (1 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/controller/StoreImageController.java (1 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/service/StoreImageService.java (4 hunks)
• nowait-infra/src/main/java/com/nowait/infraaws/aws/s3/S3Service.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch refactor/#4-Image-resizing

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.