fix(Reservation): 주문 상태 MismatchedInputException 버그 해결

[Jjiggu]

작업 요약

• 주문 상태 MismatchedInputException 버그 해결

Issue Link

#166

문제점 및 어려움

• enum 리터럴 "CALLING"이 아니라 객체 형태여서 MismatchedInputException이 발생

해결 방안

• ReservationStatusRequest 요청 DTO 정의

Reference

Summary by CodeRabbit

• 신규 기능

  • 예약 상태 변경 시, 상태 값을 URL 대신 요청 본문에서 전달하도록 개선되었습니다.

• 스타일

  • 일부 코드의 가독성을 높이기 위한 정렬 및 공백 등 코드 스타일이 개선되었습니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

"""

Walkthrough

ReservationController의 예약 상태 변경 PATCH 엔드포인트가 기존의 path variable 방식에서 request body로 상태를 받는 방식으로 변경되었습니다. 이를 위해 ReservationStatusRequest DTO가 새로 추가되었고, 서비스와 enum에는 코드 포맷팅 및 스타일 정리만 적용되었습니다.

Changes

파일/경로	변경 요약
.../reservation/controller/ReservationController.java	PATCH 엔드포인트에서 status path variable 제거, request body(DTO)로 상태 전달 방식으로 수정, 메서드 시그니처 변경
.../reservation/dto/ReservationStatusRequest.java	ReservationStatusRequest DTO 신설, status 필드 및 Lombok 어노테이션 추가
.../reservation/service/ReservationService.java	코드 포맷팅 및 스타일 정리, 논리/기능 변화 없음
.../common/enums/ReservationStatus.java	enum 선언 내 쉼표 뒤 공백 추가(스타일 변경)

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ReservationController
    participant ReservationService

    Client->>ReservationController: PATCH /stores/{storeId}/reservations/{userId} \n (body: ReservationStatusRequest)
    ReservationController->>ReservationService: updateEntry(storeId, userId, request.status, memberDetails)
    ReservationService-->>ReservationController: 처리 결과 반환
    ReservationController-->>Client: Response 반환

Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Possibly related PRs

• feat(Store,Reservation): 예약 많은/적은순 정렬 로직 개선 #151: ReservationController의 updateEntry 메서드에 대해 HTTP 메서드 어노테이션만 변경하지만, 동일 메서드 시그니처와 요청 처리 부분을 수정하므로 직접적으로 관련 있음.
• feat(Order,Reservation): 주문 조회 응답 데이터 개선 및 대기열 CRUD 구현 #140: ReservationController의 updateEntry 메서드에 대해 status를 path variable로 받는 POST 엔드포인트를 추가하며, 예약 상태 변경 처리 방식에 관여하므로 관련성이 높음.
  """

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd9c72e and 87c7907.

📒 Files selected for processing (4)

• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/reservation/controller/ReservationController.java (2 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/reservation/dto/ReservationStatusRequest.java (1 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/reservation/service/ReservationService.java (8 hunks)
• nowait-common/src/main/java/com/nowait/common/enums/ReservationStatus.java (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix#166-fix-NonUniqueResultException

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.