Skip to content

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Jul 29, 2025

작업 요약

  • noticeTile 컬럼 추가
  • dto 내 noticeTile 추가
  • notice컬럼 noticeContent로 이름 변경

Issue Link

#181

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 신규 기능

    • 매장 공지사항이 기존의 단일 필드에서 '공지 제목'과 '공지 내용'으로 분리되어 표시됩니다.
  • 버그 수정

    • 매장 정보 생성, 조회, 수정 시 공지사항이 제목과 내용으로 명확하게 구분되어 입력 및 출력됩니다.

@Jjiggu Jjiggu self-assigned this Jul 29, 2025
@Jjiggu Jjiggu added the refactor 리팩토링 label Jul 29, 2025
@Jjiggu Jjiggu merged commit 4e2ed48 into develop Jul 29, 2025
1 check passed
@coderabbitai
Copy link

coderabbitai bot commented Jul 29, 2025

Caution

Review failed

The pull request is closed.

"""

Walkthrough

단일 문자열 필드였던 noticenoticeTitlenoticeContent라는 두 개의 필드로 분리되었습니다. 이에 따라 Store 엔티티, DTO, 서비스 구현 등에서 관련 필드, 생성자, 메서드 시그니처 및 매핑 로직이 모두 수정되었습니다.

Changes

Cohort / File(s) Change Summary
Store 엔티티 및 서비스
nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/store/entity/Store.java,
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/service/StoreServiceImpl.java
Store 엔티티의 notice 필드를 noticeTitlenoticeContent로 분리. 생성자, updateInfo 메서드 시그니처 및 구현부도 이 변경을 반영하도록 수정. 서비스에서 업데이트 시 두 필드로 분리 전달.
관리자용 Store DTO
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/dto/StoreCreateRequest.java,
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/dto/StoreCreateResponse.java,
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/dto/StoreReadDto.java,
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/dto/StoreUpdateRequest.java
DTO 내 notice 필드를 noticeTitlenoticeContent로 분리. 관련 팩토리 메서드 및 매핑 로직도 두 필드로 변경.
사용자용 Store DTO
nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/dto/StoreDetailReadResponse.java,
nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/dto/StorePageReadResponse.java
사용자용 응답 DTO에서도 noticenoticeTitle, noticeContent로 분리. 팩토리 메서드 및 매핑 로직 수정.

Sequence Diagram(s)

sequenceDiagram
    participant Admin as Admin API
    participant StoreService as StoreServiceImpl
    participant StoreEntity as Store

    Admin->>StoreService: updateStore(StoreUpdateRequest)
    StoreService->>StoreEntity: updateInfo(name, location, description, noticeTitle, noticeContent, openTime)
    StoreEntity-->>StoreService: (업데이트 완료)
    StoreService-->>Admin: StoreReadDto (noticeTitle, noticeContent 포함)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20분

Suggested reviewers

  • HyemIin
    """

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 581ed75 and af5b16d.

📒 Files selected for processing (8)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/dto/StoreCreateRequest.java (1 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/dto/StoreCreateResponse.java (2 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/dto/StoreReadDto.java (2 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/dto/StoreUpdateRequest.java (1 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/store/service/StoreServiceImpl.java (1 hunks)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/dto/StoreDetailReadResponse.java (2 hunks)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/dto/StorePageReadResponse.java (2 hunks)
  • nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/store/entity/Store.java (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#181-add-noticeTitle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants