refactor(APM): admin 대시보드 접근권한 설정

[Jjiggu]

작업 요약

admin 대시보드 접근권한 설정

Issue Link

#206

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

• 버그 수정

  • 관리 및 사용자 API 애플리케이션에서 코드에 영향을 주지 않는 공백 줄이 추가/제거되었습니다.

• 기능 개선

  • "/nowait/management" 경로에 대한 비인증 접근이 명확히 허용되어 접근성이 향상되었습니다.

• 배포

  • 관리 및 사용자 Docker 배포 스크립트에서 Prometheus와 Grafana 컨테이너의 강제 종료 및 삭제 단계가 제거되어, 해당 컨테이너의 상태가 더 안전하게 유지됩니다.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

이 변경 사항은 두 Java 애플리케이션 진입점 파일의 마지막 빈 줄을 추가/제거하고, 관리 API의 Spring Security 설정에서 특정 엔드포인트의 접근 허용 범위를 수정했으며, 두 Docker 배포 스크립트에서 Prometheus 및 Grafana 컨테이너를 명시적으로 중지/삭제하는 로직을 제거했습니다.

Changes

Cohort / File(s)	Change Summary
Java 파일 마지막 줄 공백 수정 nowait-app-admin-api/src/main/java/com/nowait/ApiAdminApplication.java, nowait-app-user-api/src/main/java/com/nowait/ApiUserApplication.java	각 파일의 마지막 빈 줄을 추가(관리 API) 또는 제거(사용자 API)함. 코드 로직에는 영향 없음.
Spring Security 엔드포인트 허용 범위 수정 nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/config/security/SecurityConfig.java	/nowait/management 경로(정확히 일치)도 인증 없이 접근 허용하도록 허용 엔드포인트 목록에 추가. 기존의 /nowait/management/**(하위 경로 전체) 허용은 그대로 유지.
Docker 배포 스크립트에서 Prometheus/Grafana 컨테이너 삭제 로직 제거 scripts/deploy-admin-docker.sh, scripts/deploy-user-docker.sh	Prometheus 및 Grafana 컨테이너의 존재 여부 확인 및 강제 삭제하는 조건문과 명령어 제거. 이제 메인 앱 컨테이너만 중지 및 삭제함. 나머지 컨테이너는 이후 단계에서 그대로 실행.

Sequence Diagram(s)

(해당 변경은 단순한 설정 및 스크립트 수정이므로 시퀀스 다이어그램 생략)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• chore: CI/CD 스크립트 추가 #18: 동일 파일에서 마지막 줄 공백만을 수정한 PR로, 이번 PR과 동일한 유형의 변경이 포함됨.
• chore: CI/CD 스크립트 수정 #24: ApiAdminApplication.java에서 마지막 줄 공백 추가가 동일하게 적용된 PR.
• refactor: 재배포를 위한 코드 수정 #59: ApiAdminApplication.java 및 ApiUserApplication.java 파일의 마지막 줄 공백만을 수정한 PR로, 이번 PR과 직접적으로 유사함.

Suggested labels

refactor

Suggested reviewers

• HyemIin

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3818880 and 18614fa.

📒 Files selected for processing (5)

• nowait-app-admin-api/src/main/java/com/nowait/ApiAdminApplication.java (1 hunks)
• nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/config/security/SecurityConfig.java (1 hunks)
• nowait-app-user-api/src/main/java/com/nowait/ApiUserApplication.java (0 hunks)
• scripts/deploy-admin-docker.sh (0 hunks)
• scripts/deploy-user-docker.sh (0 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feature/#206-prometheus-grafana

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.