Skip to content

Conversation

@Jjiggu
Copy link
Contributor

@Jjiggu Jjiggu commented Aug 5, 2025

작업 요약

프론트 배포주소 추가

Issue Link

#243

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

@Jjiggu Jjiggu self-assigned this Aug 5, 2025
@Jjiggu Jjiggu added the refactor 리팩토링 label Aug 5, 2025
@coderabbitai
Copy link

coderabbitai bot commented Aug 5, 2025

Walkthrough

CORS 설정 파일이 업데이트되어 허용된 origin 목록에 세 개의 프로덕션 URL이 추가되었습니다. 기존에는 로컬호스트 두 개만 허용되었으나, 이제 프로덕션 도메인 세 개가 추가로 허용됩니다. 그 외의 설정은 변경되지 않았습니다.

Changes

Cohort / File(s) Change Summary
CORS Origin 확장
nowait-app-user-api/src/main/java/com/nowait/applicationuser/config/security/CorsConfig.java
허용 origin 목록에 프로덕션 URL 세 개 추가, 기존 로컬호스트 두 개는 유지됨. 기타 설정은 변경 없음.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • HyemIin
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#243-upgrade-java-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
nowait-app-user-api/src/main/java/com/nowait/applicationuser/config/security/CorsConfig.java (2)

17-23: setAllowCredentials가 두 번 호출되어 있습니다
Line 17과 Line 22에서 동일한 설정을 반복하고 있습니다. 중복 호출은 동작에는 영향을 주지 않으나 가독성을 떨어뜨리고 유지보수 시 혼란을 줄 수 있습니다. 한 번만 호출하도록 정리해 주세요.

-        config.setAllowCredentials(true); // 쿠키나 인증헤더 자격증명 허용
...
-        config.setAllowCredentials(true); // 쿠키 포함 허용
+        config.setAllowCredentials(true); // 쿠키·인증 헤더 자격증명 허용

18-18: 허용 Origin 하드코딩 대신 프로퍼티로 외부화 권장
배포 URL이 늘어날 때마다 소스를 수정·재배포해야 합니다.
application.yml(또는 환경 변수)로 리스트를 주입받아 @Value@ConfigurationProperties로 바인딩하면 운영/스테이징 환경별로 유연하게 관리할 수 있습니다. 또한 *.nowait.co.kr 과 같이 서브도메인을 포함하려면 setAllowedOriginPatterns를 사용하는 편이 더 안전합니다.

예시:

@Value("${cors.allowed-origins}")
private List<String> allowedOrigins;

@Bean
public CorsConfigurationSource corsConfigurationSource() {
    CorsConfiguration config = new CorsConfiguration();
    config.setAllowCredentials(true);
    config.setAllowedOrigins(allowedOrigins);
    ...
}
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44aae02 and 3522a09.

📒 Files selected for processing (1)
  • nowait-app-user-api/src/main/java/com/nowait/applicationuser/config/security/CorsConfig.java (1 hunks)

@Jjiggu Jjiggu merged commit 4cfd8e0 into develop Aug 5, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants